Correct SA1629 to add a period if the documentation ends in an xml entity. Previously replaced the semicolon in the xml entity. #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3859 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 926 926
Lines 110188 110202 +14
Branches 3312 3312
=======================================
+ Hits 107384 107398 +14
Misses 1837 1837
Partials 967 967 |
…tity. Previously replaced the semicolon in the xml entity. DotNetAnalyzers#3802
bjornhellander
force-pushed
the
feature/sa1629-xml-entity-3802
branch
from
eb71e07 to
cc18acf
Compare
sharwell
reviewed
Jun 7, 2024
...Analyzers/StyleCop.Analyzers/DocumentationRules/SA1629DocumentationTextMustEndWithAPeriod.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jun 7, 2024
...Analyzers/StyleCop.Analyzers/DocumentationRules/SA1629DocumentationTextMustEndWithAPeriod.cs
Outdated
Show resolved
Hide resolved
bjornhellander
force-pushed
the
feature/sa1629-xml-entity-3802
branch
from
2c5e1d3 to
a5c1d42
Compare
sharwell
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3802.